@Test public void shouldCreateMetricWithDefaultValues() { Metric metric = new Metric.Builder("foo", "Foo", Metric.ValueType.INT) .create(); assertThat(metric.getBestValue()).isNull(); assertThat(metric.getDescription()).isNull(); assertThat(metric.getWorstValue()).isNull(); assertThat(metric.getDirection()).isEqualTo(Metric.DIRECTION_NONE); assertThat(metric.getEnabled()).isTrue(); assertThat(metric.getId()).isNull(); assertThat(metric.getUserManaged()).isFalse(); assertThat(metric.isHidden()).isFalse(); assertThat(metric.isOptimizedBestValue()).isFalse(); }
@Test public void all_core_metrics_are_in_core_bundle() { List<Metric> coreMetrics = CoreMetrics.getMetrics(); List<String> incorrectMetricDefinitions = new ArrayList<>(); for (Metric metric : coreMetrics) { if (metric.isHidden()) { continue; } String metricNamePropertyKey = "metric." + metric.getKey() + ".name"; String l10nMetricName = underTest.message(Locale.ENGLISH, metricNamePropertyKey, null); if (l10nMetricName == null) { incorrectMetricDefinitions.add(metricNamePropertyKey + "=" + metric.getName()); } else if (!l10nMetricName.equals(metric.getName())) { incorrectMetricDefinitions.add(metricNamePropertyKey + " is not consistent in core bundle and CoreMetrics"); } String metricDescriptionPropertyKey = "metric." + metric.getKey() + ".description"; String l10nMetricDescription = underTest.message(Locale.ENGLISH, metricDescriptionPropertyKey, null); if (l10nMetricDescription == null) { incorrectMetricDefinitions.add(metricDescriptionPropertyKey + "=" + metric.getDescription()); } else if (!l10nMetricDescription.equals(metric.getDescription())) { incorrectMetricDefinitions.add(metricDescriptionPropertyKey + " is not consistent in core bundle and CoreMetrics"); } } assertThat(incorrectMetricDefinitions).as("Metric definitions to fix in core bundle", incorrectMetricDefinitions.size()).isEmpty(); }
@Override @Nonnull public MetricDto apply(@Nonnull Metric metric) { MetricDto dto = new MetricDto(); dto.setId(metric.getId()); dto.setKey(metric.getKey()); dto.setDescription(metric.getDescription()); dto.setShortName(metric.getName()); dto.setBestValue(metric.getBestValue()); dto.setDomain(metric.getDomain()); dto.setEnabled(metric.getEnabled()); dto.setDirection(metric.getDirection()); dto.setHidden(metric.isHidden()); dto.setQualitative(metric.getQualitative()); dto.setValueType(metric.getType().name()); dto.setOptimizedBestValue(metric.isOptimizedBestValue()); dto.setUserManaged(metric.getUserManaged()); dto.setWorstValue(metric.getWorstValue()); dto.setDeleteHistoricalData(metric.getDeleteHistoricalData()); dto.setDecimalScale(metric.getDecimalScale()); return dto; } }
@Override @Nonnull public MetricDto apply(@Nonnull Metric metric) { MetricDto dto = new MetricDto(); dto.setId(metric.getId()); dto.setKey(metric.getKey()); dto.setDescription(metric.getDescription()); dto.setShortName(metric.getName()); dto.setBestValue(metric.getBestValue()); dto.setDomain(metric.getDomain()); dto.setEnabled(metric.getEnabled()); dto.setDirection(metric.getDirection()); dto.setHidden(metric.isHidden()); dto.setQualitative(metric.getQualitative()); dto.setValueType(metric.getType().name()); dto.setOptimizedBestValue(metric.isOptimizedBestValue()); dto.setUserManaged(metric.getUserManaged()); dto.setWorstValue(metric.getWorstValue()); dto.setDeleteHistoricalData(metric.getDeleteHistoricalData()); dto.setDecimalScale(metric.getDecimalScale()); return dto; } }